pki: honor skip_install_trust for explicit tls internal issuers#7894
Open
gautamrizwani wants to merge 1 commit into
Open
pki: honor skip_install_trust for explicit tls internal issuers#7894gautamrizwani wants to merge 1 commit into
gautamrizwani wants to merge 1 commit into
Conversation
Site-level tls internal creates its own CA independently of auto_https, silently ignoring skip_install_trust. Fixes caddyserver#7893
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Site-level
tls internalcreates its own CA independently ofauto_https. SincebuildPKIApp()only pre-registered a CA withinstall_trust: falsewhenauto_httpswasn't fully disabled, that CA was instead created later at runtime with trust installation left on wheneverauto_httpswas off, silently ignoringskip_install_trust.This adds a check that looks at each site's configured internal issuer (matched by type, so it covers both the shorthand and the explicit
ca <id>form) and registers its CA withinstall_trust: false, regardless ofauto_https.Added tests for: the default
localCA case, a custom-named CA via the explicit issuer form, and a no-regression check that nopkiapp is emitted when no site uses an internal issuer.Fixes #7893
Assistance Disclosure
Traced the root cause and verified the fix, used Claude to help draft parts of the code and tests, reviewed each line before submitting.